This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Simplify RuleEngine API#151
Open
dejabot wants to merge 2 commits into
Open
Conversation
…urn a Rule that can be modified further, eg with a finishedTriggeringProcedure.
this prevents accidental modification of rules after the containing ruleengine starts getting used. also switch to a LinkedHashMap for storing rules and tweak some of the methods used in unit tests.
Member
|
Do you want to open this in 2025 instead? |
rcahoon
reviewed
Jan 10, 2025
| * // add rule to spin up the shooter when the boxop presses the right trigger on the gamepad | ||
| * rules.add(Rule.create("spin up shooter", gamepad.getButton(InputConstants.XBOX_RT)). | ||
| * withNewlyTriggeringProcedure(() -> new ShooterSpin(shooter))); | ||
| * rules.add("spin up shooter", gamepad.getButton(InputConstants.XBOX_RT), |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
Rule.Builder. Callers still callRuleEngine.addRule(), with simplified syntax. AllowRules to be modified, eg to specify a finishedTriggering action - but onceRuleEngine.run()is called, "seal" theRuleEngine'sRules so they cannot be modified further.How Has This Been Tested?